Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access to session_id #63

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

rustaceanrob
Copy link
Collaborator

@rustaceanrob rustaceanrob commented Sep 14, 2024

Each packet handler should be one-to-one with a session ID, so I allow access to a field on the struct here. Resolves #61

cc @nyonson @Kixunil

Copy link
Collaborator

@nyonson nyonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d3eaa82

I am a little curious what the use case is for this, just to better understand. Like, maybe two parties have multiple encrypted channels between each other?

@Kixunil
Copy link
Contributor

Kixunil commented Sep 15, 2024

@nyonson detection of active tampering if you can compare the session ID out-of-band.

Copy link
Contributor

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d3eaa82

@rustaceanrob rustaceanrob merged commit 18f66a9 into rust-bitcoin:main Sep 15, 2024
7 checks passed
@rustaceanrob rustaceanrob deleted the session-id-09-13 branch September 15, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow retrieving session ID
3 participants